Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update column type for raw_data.Demultiplexed_Reads #74

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

TCLamnidis
Copy link
Member

Should fix #73.

@TCLamnidis TCLamnidis requested review from nevrome and jfy133 December 13, 2024 13:27
@jfy133
Copy link
Member

jfy133 commented Dec 13, 2024

You need to rebuild the data hash files too

@TCLamnidis
Copy link
Member Author

Running data-raw/data_prep.R I got a warning:

> pandora_column_types <- readr::read_tsv(
+   "data-raw/pandora_column_types.tsv",
+   col_types = readr::cols(
+     table = readr::col_character(),
+     entity_type = readr::col_character(),
+     col_name = readr::col_character(),
+     type = readr::col_character(),
+     auxiliary_table = readr::col_character(),
+     update_col_type = readr::col_character()
+   )
+ )
Warning message:                                                                                                                                                                      
One or more parsing issues, call `problems()` on your data frame for details, e.g.:
  dat <- vroom(...)
  problems(dat) 
> readr::problems()
# A tibble: 4 × 5
    row   col expected  actual    file                                                                                    
  <int> <int> <chr>     <chr>     <chr>                                                                                   
1   104     8 7 columns 8 columns /Users/lamnidis/Software/github/TCLamnidis/sidora.core/data-raw/pandora_column_types.tsv
2   145     8 7 columns 8 columns /Users/lamnidis/Software/github/TCLamnidis/sidora.core/data-raw/pandora_column_types.tsv
3   176     8 7 columns 8 columns /Users/lamnidis/Software/github/TCLamnidis/sidora.core/data-raw/pandora_column_types.tsv
4   204     8 7 columns 8 columns /Users/lamnidis/Software/github/TCLamnidis/sidora.core/data-raw/pandora_column_types.tsv

It looks like those columns all came from #71. I assumed there to be an extra NA introduced as a copy-paste error and recreated the hash files with that change included, but please check.

@TCLamnidis TCLamnidis merged commit 095df1b into sidora-tools:master Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integer overflow warning
2 participants