fix: image cache volume provisioning #10281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMV
approved these changes
Feb 3, 2025
smira
force-pushed
the
fix/image-cache-volume
branch
from
6bcd1b2 to
7c46eba
Compare
There is a logic failure in the `ImageCacheConfig` controller that `allReady` was always `false` (now should be fixed). The real issue was that `IMAGECACHE` being in the `SystemDisk` wave, and not being provisioned until `EPHEMERAL` is not provisioned, which blocks booting with Image Cache on and without an ISO, by just providing an empty `IMAGECACHE` disk volume. There isn't much use in this scenario, but still good to make it fixed. Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
fix/image-cache-volume
branch
from
7c46eba to
5e28c8e
Compare
frezbo
reviewed
Feb 4, 2025
| @@ -490,7 +490,7 @@ uki-certs: talosctl ## Generate test certificates for SecureBoot/PCR Signing | |||
| .PHONY: cache-create | |||
| cache-create: installer imager ## Generate image cache. | |||
| @docker run --entrypoint /usr/local/bin/e2e.test registry.k8s.io/conformance:$(KUBECTL_VERSION) --list-images | \ | |||
| $(TALOSCTL_EXECUTABLE) images integration --installer-tag=$(IMAGE_TAG) --registry-and-user=$(REGISTRY_AND_USERNAME) | \ | |||
| $(TALOSCTL_EXECUTABLE) images integration --installer-tag=$(IMAGE_TAG)-amd64-secureboot --registry-and-user=$(REGISTRY_AND_USERNAME) | \ | |||
There was a problem hiding this comment.
I guess unrelated to this, but to make the default secureboot installer?
There was a problem hiding this comment.
it is in fact related, the change you did to make ISO sd-boot broke image-cache, as it needs to cache a different installer image
There was a problem hiding this comment.
so I think we should figure out a plan vs. the installer and start using UKIfied installer everywhere now, but it doesn't have to be the this PR
frezbo
approved these changes
Feb 4, 2025
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a logic failure in the
ImageCacheConfigcontroller thatallReadywas alwaysfalse(now should be fixed).The real issue was that
IMAGECACHEbeing in theSystemDiskwave, and not being provisioned untilEPHEMERALis not provisioned, which blocks booting with Image Cache on and without an ISO, by just providing an emptyIMAGECACHEdisk volume. There isn't much use in this scenario, but still good to make it fixed.