feat: add the new rust-based xen-guest-agent as extension #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
reviewed
Mar 8, 2024
frezbo
reviewed
Mar 8, 2024
frezbo
reviewed
Mar 8, 2024
guest-agents/vars.yaml
Outdated
| @@ -6,3 +6,5 @@ GLIB_VERSION: 2.79.2 | |||
| PCRE2_VERSION: 10.42 | |||
| # renovate: datasource=github-releases extractVersion=^v(?<version>.*)$ depName=xenserver/xe-guest-utilities | |||
| XE_GUEST_UTILITIES_VERSION: 8.4.0 | |||
There was a problem hiding this comment.
I think so, it will reduce the confusion for new users
frezbo
reviewed
Mar 8, 2024
|
/ok-to-test |
frezbo
approved these changes
Mar 8, 2024
smira
approved these changes
Mar 11, 2024
Adds new rust-based `xen-guest-agent` extension. Also remove the old `xe-guest-utilities`. Signed-off-by: Noel Georgi <[email protected]>
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing xe-guest-utilities extension is based on xenserver/xe-guest-utilities which appears to be abandoned in favour of new the rust-based guest agent. Moreover the existing guest-utilities is largely a go-wrapper around a bunch of command line tools. Memory is the only metric that it seems to be reporting as it just parses the /proc/meminfo file, rest of the metrics are collected using command line tools that don't exist in Talos and so it fails silently.
This PR adds the new guest agent and it also fixes issue#323