Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass classes to editor element #64

Merged
merged 4 commits into from
Dec 1, 2024
Merged

Conversation

knd775
Copy link
Contributor

@knd775 knd775 commented Nov 6, 2024

No description provided.

@sibiraj-s
Copy link
Owner

PR looks good, I'll double check once if there won't be any conflicts with tiptap classes, if used like this. Just a doubt.

Meanwhile if required now, I'd recommend using https://tiptap.dev/docs/editor/api/editor#editorprops if classes not dynamic

@rice-cracker-dev
Copy link

@sibiraj-s any update on this PR?

@sibiraj-s
Copy link
Owner

My bad i forgot. Will check and merge.

@sibiraj-s sibiraj-s enabled auto-merge (squash) December 1, 2024 10:05
@sibiraj-s sibiraj-s merged commit 902ed66 into sibiraj-s:master Dec 1, 2024
2 checks passed
@sibiraj-s
Copy link
Owner

Available in v2.1.0, note this passes the class to the editor container. Not the editor itself, to set the class on editor. You would still need to do via editor props https://tiptap.dev/docs/editor/api/editor#editorprops

@knd775
Copy link
Contributor Author

knd775 commented Dec 2, 2024

Available in v2.1.0, note this passes the class to the editor container. Not the editor itself, to set the class on editor. You would still need to do via editor props tiptap.dev/docs/editor/api/editor#editorprops

Yep, this is what I was going for. This was something specific we needed when switching from our own solution to this library. Thanks for merging!

@knd775 knd775 deleted the patch-1 branch December 2, 2024 20:09
Copy link

github-actions bot commented Jan 5, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants