Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly specify various missing trait impls #26

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Explicitly specify various missing trait impls #26

merged 3 commits into from
Aug 7, 2024

Conversation

michaelsutton
Copy link
Contributor

  1. Implement Clone, Default for custom Argument types
  2. Expose map iterator as DoubleEnded, ExactSize, Fused

shuoli84
shuoli84 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Owner

@shuoli84 shuoli84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuoli84 shuoli84 merged commit 72631e6 into shuoli84:main Aug 7, 2024
1 check passed
@shuoli84
Copy link
Owner

shuoli84 commented Aug 7, 2024

thanks

@michaelsutton michaelsutton deleted the impls branch August 7, 2024 07:29
@michaelsutton
Copy link
Contributor Author

thanks

Would you like work to be done for fixing new clippy warnings?

@shuoli84
Copy link
Owner

shuoli84 commented Aug 7, 2024

@michaelsutton that will be great. It's been a while since my last change, I also need some time to pick it up. Would you like to open a PR? I'll do what I can do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuoli84 shuoli84 shuoli84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsutton @shuoli84