Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix issue spesmilo#105 Thread Exception When building database
Go into wait_on_bitcoind instead of raising an exception when an unexpected bitcoind error number is returned. This allows the server to wait for bitcoind rather than just bailing out with.
- Loading branch information
6f30dcb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted this commit because it makes the server trivially vulnerable; it will close all sessions everytime a client performs a request that returns an error.
6f30dcb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this change can potentially get us into an error loop with a bitcoind request that can never be satisfied.
Maybe a better solution would be a try/catch up it the top of do_catch_up.
It was an exception bubbling up to that function that kills the service in the original issue report.