Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trackSql action to handle generated sql and params #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add trackSql action to handle generated sql and params #1

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89df7f9
Add trackSql action
igor-dv Jan 24, 2018
e88dd4d
Add parameters to the trackSql func as well
igor-dv Jan 25, 2018
708af3f
Add SqlDescriptor class and use it in trackSql func instead of the fl…
igor-dv Jan 25, 2018
4efc720
Extract TrackSql and suppress exception if it happens
igor-dv Jan 25, 2018
a3fb301
Add to Sanity
igor-dv Jan 25, 2018
edffb07
Bump minor
igor-dv Jan 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/OhioBox.Moranbernate/Querying/QueryExt.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,16 @@ public static T GetById<T>(this IDbConnection connection, object id)
return Run<T>(connection, sql, parameters, generator.GetColumns()).FirstOrDefault();
}

public static long Count<T>(this IDbConnection connection, Action<IRestrictable<T>> restrictions = null)
public static long Count<T>(this IDbConnection connection, Action<IRestrictable<T>> restrictions = null, Action<string> trackSql = null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use an object instead of string + list of obj - it will enable us to extend it later without breaking the contract

where T : class, new()
{
var countByQuery = new CountByQuery<T>();

var parameters = new List<object>();
var sql = countByQuery.GetSql(restrictions, parameters);

trackSql?.Invoke(sql);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the parameters


using (var command = connection.CreateCommand())
{
command.CommandText = sql;
Expand All @@ -35,30 +37,33 @@ public static long Count<T>(this IDbConnection connection, Action<IRestrictable<
}
}

public static IEnumerable<T> Query<T>(this IDbConnection connection, Action<IQueryBuilder<T>> query = null)
public static IEnumerable<T> Query<T>(this IDbConnection connection, Action<IQueryBuilder<T>> query = null, Action<string> trackSql = null)
where T : class, new()
{
var builder = new QueryBuilder<T>();
if (query != null)
query(builder);
query?.Invoke(builder);

var parameters = new List<object>();
var sql = builder.Build(parameters);

trackSql?.Invoke(sql);

return Run<T>(connection, sql, parameters, builder.Properties);
}

public static IEnumerable<QueryResult<T>> QueryAggregated<T>(this IDbConnection connection, Action<IQueryBuilder<T>> query = null)
public static IEnumerable<QueryResult<T>> QueryAggregated<T>(this IDbConnection connection, Action<IQueryBuilder<T>> query = null, Action<string> trackSql = null)
where T : class, new()
{
var builder = new QueryBuilder<T>();
if (query != null)
query(builder);
query?.Invoke(builder);

builder.RowCount();

var parameters = new List<object>();
var sql = builder.Build(parameters);

trackSql?.Invoke(sql);

using (var command = connection.CreateCommand())
{
command.CommandText = sql;
Expand Down Expand Up @@ -127,7 +132,7 @@ private static IEnumerable<T> Run<T>(IDbConnection connection, string sql, List<
}
}

private static void HandleSetValueException<T>(string sql, List<object> parameters, IDataReader reader, IDbConnection connection, Exception ex)
private static void HandleSetValueException<T>(string sql, IList<object> parameters, IDataReader reader, IDbConnection connection, Exception ex)
where T : class, new()
{
Exception e;
Expand Down