Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Looping of data by reference with null coalescing #2829

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

aragon999
Copy link
Contributor

1. Why is this change necessary?

When looping through an array, where a reference is used, the original data is not the same reference, when null coalescing is used, see: https://3v4l.org/oU3is

Hence the data is not properly modified.

2. What does this change do, exactly?

Check if the values are a non-empty array and remove the null coalescing.

3. Describe each step to reproduce the issue or behaviour.

-

4. Please link to the relevant issues (if any).

-

5. Which documentation changes (if any) need to be made because of this PR?

-

6. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

Copy link

Warnings
⚠️ The Pull Request doesn't contain any changes to the Upgrade file

@aragon999 aragon999 requested a review from mitelg January 26, 2025 14:17
@mitelg mitelg merged commit f112da4 into shopware5:5.7 Jan 27, 2025
25 checks passed
@mitelg
Copy link
Contributor

mitelg commented Jan 27, 2025

thanks for your contribution @aragon999 👍🎉💙

@aragon999 aragon999 deleted the fix/loop-null-coalescing branch January 27, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants