Skip to content

Commit

Permalink
fix: wrong usage of default
Browse files Browse the repository at this point in the history
  • Loading branch information
TrayserCassa committed Jan 13, 2025
1 parent ea41099 commit 407f817
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 18 deletions.
33 changes: 16 additions & 17 deletions .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,25 @@ jobs:
# run: go test ./...

test-on-cluster:
name: Cluster test
name: Cluster E2E Test
runs-on: runs-on=${{ github.run_id }}/runner=sw-amd64/cpu=4
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Create Snapshot
id: goreleaser
uses: goreleaser/goreleaser-action@v6
with:
distribution: goreleaser
version: "~> v1"
args: release --clean --snapshot
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# Needed for controler runtime
- name: Setup Go
uses: actions/setup-go@v5
with:
Expand All @@ -56,30 +67,18 @@ jobs:
with:
version: v3.16.4

- uses: actions/setup-python@v5
with:
python-version: "3.x"
check-latest: true

- name: Create k8s Kind Cluster
uses: helm/kind-action@v1

# - name: Create Snapshot
# uses: goreleaser/goreleaser-action@v6
# with:
# distribution: goreleaser
# version: '~> v1'
# args: release --clean --snapshot
# env:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Run chart-testing (install)
run: |
make helm path=test version=99.99.99
cd test
kubectl create namespace test
helm install test --namespace test .
kubectl wait --namespace test --for=condition=available --timeout=90s deployment/test-shopware-operator
helm install test --namespace test . --set image.tag="${{ steps.goreleaser.outputs.version }}"
kubectl wait --namespace test --for=condition=Available --timeout=90s deployment/test-shopware-operator
kubectl get deployment --namespace test -o json
kubectl get pods --namespace test -o json
# - name: Run chart-testing (test)
# run: |
Expand Down
2 changes: 1 addition & 1 deletion api/v1/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ type StoreSpec struct {
HorizontalPodAutoscaler HPASpec `json:"horizontalPodAutoscaler,omitempty"`
ServiceAccountName string `json:"serviceAccountName,omitempty"`

// +kubebuilder:default={Currency: "EURO", Locale: "en-GB"}
// +kubebuilder:default={currency: "EURO", locale: "en-GB"}
ShopConfiguration Configuration `json:"shopConfiguration,omitempty"`

// +kubebuilder:default=false
Expand Down

0 comments on commit 407f817

Please sign in to comment.