Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dynamically build the my.cnf #11

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

mkraeml
Copy link
Contributor

@mkraeml mkraeml commented Oct 30, 2024

The current Configure MySQL Client step is broken, as it overwrites instead of appends to the .my.cnf (> vs >>).
And as we already get all information for the MySQL connection from the DATABASE_URL, we can also extract those and fill the .my.cnf with it.

@shyim
Copy link
Member

shyim commented Oct 30, 2024

Why is overwriting a problem?

@mkraeml
Copy link
Contributor Author

mkraeml commented Oct 31, 2024

Why is overwriting a problem?

Overwriting is not directly a problem (my new code also overwrites the config), but we used > every time, so the file only has user=root as content instead of

[client]
host=127.0.0.1
user=root

And then the mysql client crashes because of a invalid config

@philipreinken
Copy link
Contributor

I'd say LGTM - @shyim any blockers from your point of view?

@philipreinken philipreinken merged commit 7ee1899 into main Nov 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants