Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEXT-33861 - improve selector #71

Merged
merged 1 commit into from
Mar 5, 2024
Merged

NEXT-33861 - improve selector #71

merged 1 commit into from
Mar 5, 2024

Conversation

jleifeld
Copy link
Contributor

What?

Update the selectors in datasets to add more functionalities

Why?

The selectors in the datasets was using Lodash "get" and was very limited

How?

Replace it with better alternative

Testing?

See tests

@vercel Vercel
Copy link

vercel bot commented Feb 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-admin-sdk-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 3:15pm
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 3:15pm

@jleifeld jleifeld force-pushed the next-33861/improve-selector branch from 951729d to 13bf13c Compare February 28, 2024 15:52
@seggewiss seggewiss added the package: admin-sdk @meteor/admin-sdk label Mar 2, 2024
@seggewiss seggewiss force-pushed the next-33861/improve-selector branch 2 times, most recently from 6173a33 to 56e998f Compare March 5, 2024 14:45
@seggewiss seggewiss force-pushed the next-33861/improve-selector branch 3 times, most recently from e472180 to d498c86 Compare March 5, 2024 14:48
@seggewiss seggewiss force-pushed the next-33861/improve-selector branch from d498c86 to f3e49c9 Compare March 5, 2024 14:57
@seggewiss seggewiss self-assigned this Mar 5, 2024
@seggewiss seggewiss requested a review from Haberkamp March 5, 2024 15:02
jleifeld
jleifeld commented Mar 5, 2024
View reviewed changes
Copy link
Contributor Author

@jleifeld jleifeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only thing missing is a changelog :)

@seggewiss seggewiss force-pushed the next-33861/improve-selector branch from f3e49c9 to 4d10acc Compare March 5, 2024 15:06
@seggewiss seggewiss marked this pull request as ready for review March 5, 2024 15:10
@seggewiss seggewiss force-pushed the next-33861/improve-selector branch from 4d10acc to cb3b487 Compare March 5, 2024 15:12
@seggewiss seggewiss merged commit 30d0128 into main Mar 5, 2024
8 checks passed
@seggewiss seggewiss deleted the next-33861/improve-selector branch March 5, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haberkamp Haberkamp Haberkamp approved these changes

Assignees

@seggewiss seggewiss

Labels
package: admin-sdk @meteor/admin-sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jleifeld @Haberkamp @seggewiss