Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix failing visual test workflow for forks #474

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Haberkamp
Copy link
Contributor

What?

This PR fixes the visual test pipeline when someone starts it by creating a fork.

Why?

The pipeline failed because of the old configuration, this only happened with forks.

How?

I just removed the ref

Testing?

If the pipeline passes everything works.

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-admin-sdk-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 10:36am
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 10:36am

@Haberkamp Haberkamp merged commit ea79f15 into main Jan 22, 2025
10 checks passed
@Haberkamp Haberkamp deleted the fix-failing-visual-test-workflow-for-forks branch January 22, 2025 10:39
Copy link

pkg-pr-new bot commented Jan 22, 2025

Open in Stackblitz

@shopware-ag/meteor-admin-sdk

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@474

@shopware-ag/stylelint-plugin-meteor

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/stylelint-plugin-meteor@474

@shopware-ag/meteor-component-library

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@474

@shopware-ag/meteor-tokens

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@474

@shopware-ag/meteor-icon-kit

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@474

commit: ed6d9d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants