fix(component-library): turn scroll bar dark in dark mode #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Lucsy3012
approved these changes
Jan 22, 2025
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/meteor-icon-kit
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-tokens
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR turns the scrollbar dark when the dark mode is enabled.
Why?
This makes makes the dark mode more visually pleasing
How?
I just added a
color-scheme: darkto the global css file.Testing?
Visit the branch preview, checkout the "Full Data Table" Story and enable the dark mode by clicking on the "Picture" icon from the Storybook toolbar, located at the top of the screen and select "Dark".
Anything Else?