Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for search #471

Merged
merged 11 commits into from
Jan 22, 2025
Merged

Add tests for search #471

merged 11 commits into from
Jan 22, 2025

Conversation

Haberkamp
Copy link
Contributor

What?

I added some unit tests for the mt-search component.

Why?

More unit tests increase our confidence that everything works as expected.

How?

I added a handful of unit tests.

Testing?

Everything is fine, when the unit tests pass, I wrote.

Anything Else?

This component now has a mix of visual test, to make sure the component looks correct and displays the correct icon. As well as some unit test to make sure it has the correct behaviour.

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 10:19am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
meteor-admin-sdk-docs ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 10:19am

alastair-simon
alastair-simon previously approved these changes Jan 22, 2025
Copy link

pkg-pr-new bot commented Jan 22, 2025

Open in Stackblitz

@shopware-ag/meteor-admin-sdk

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@471

@shopware-ag/meteor-icon-kit

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@471

@shopware-ag/stylelint-plugin-meteor

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/stylelint-plugin-meteor@471

@shopware-ag/meteor-component-library

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@471

@shopware-ag/meteor-tokens

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@471

commit: b949015

@Haberkamp Haberkamp merged commit b6ad9fe into main Jan 22, 2025
10 checks passed
@Haberkamp Haberkamp deleted the add-tests-for-search branch January 22, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants