-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for search #471
Merged
Merged
Add tests for search #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
alastair-simon
previously approved these changes
Jan 22, 2025
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-icon-kit
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-component-library
@shopware-ag/meteor-tokens
commit: |
Haberkamp
force-pushed
the
add-tests-for-search
branch
from
January 22, 2025 09:58
0b15df9
to
46d8906
Compare
alastair-simon
approved these changes
Jan 22, 2025
Lucsy3012
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I added some unit tests for the
mt-search
component.Why?
More unit tests increase our confidence that everything works as expected.
How?
I added a handful of unit tests.
Testing?
Everything is fine, when the unit tests pass, I wrote.
Anything Else?
This component now has a mix of visual test, to make sure the component looks correct and displays the correct icon. As well as some unit test to make sure it has the correct behaviour.