-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests for helptext #469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Haberkamp
force-pushed
the
add-tests-for-helptext
branch
from
January 22, 2025 06:45
ac9616d
to
161f82d
Compare
Haberkamp
force-pushed
the
add-tests-for-helptext
branch
from
January 22, 2025 06:54
f1eb6f9
to
51c4ec7
Compare
Haberkamp
force-pushed
the
add-tests-for-helptext
branch
from
January 22, 2025 07:23
7874884
to
09b6c59
Compare
alastair-simon
approved these changes
Jan 22, 2025
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-tokens
@shopware-ag/meteor-icon-kit
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I added some tests for the help-text component
Why?
More tests give us more confidence, that our system works.
How?
First I've written some tests to make sure everything works as expected, and then I did the refactoring.
Testing?
I've written a handful of tests to make sure the help-text works
Anything Else?
mt-tooltip
component, instead of thev-tooltip
directive. This improves a11y