Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for helptext #469

Merged
merged 3 commits into from
Jan 22, 2025
Merged

add tests for helptext #469

merged 3 commits into from
Jan 22, 2025

Conversation

Haberkamp
Copy link
Contributor

@Haberkamp Haberkamp commented Jan 22, 2025

What?

I added some tests for the help-text component

Why?

More tests give us more confidence, that our system works.

How?

First I've written some tests to make sure everything works as expected, and then I did the refactoring.

Testing?

I've written a handful of tests to make sure the help-text works

Anything Else?

  • Refactored the helptext to use the mt-tooltip component, instead of the v-tooltip directive. This improves a11y

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 10:11am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
meteor-admin-sdk-docs ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 10:11am

Copy link

pkg-pr-new bot commented Jan 22, 2025

Open in Stackblitz

@shopware-ag/meteor-admin-sdk

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@469

@shopware-ag/meteor-component-library

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@469

@shopware-ag/stylelint-plugin-meteor

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/stylelint-plugin-meteor@469

@shopware-ag/meteor-tokens

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@469

@shopware-ag/meteor-icon-kit

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@469

commit: 09b6c59

@Haberkamp Haberkamp merged commit e55fea5 into main Jan 22, 2025
9 checks passed
@Haberkamp Haberkamp deleted the add-tests-for-helptext branch January 22, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants