Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for banner #466

Merged
merged 8 commits into from
Jan 22, 2025
Merged

Add tests for banner #466

merged 8 commits into from
Jan 22, 2025

Conversation

Haberkamp
Copy link
Contributor

What?

I added some tests to make sure the banner component works as expected.

Why?

This increases our confidence that the banner component works as expected.

How?

I've written some unit tests and added some type definitions for the close event

Testing?

I've added a small handful of test to make sure the closing mechanism works as expected.

Anything Else?

  • I added focus state to the close button
  • I refactored the component to use spacing tokens instead of hard-coded spacing

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 9:31am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
meteor-admin-sdk-docs ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 9:31am

Lucsy3012
Lucsy3012 previously approved these changes Jan 21, 2025
Copy link

pkg-pr-new bot commented Jan 21, 2025

Open in Stackblitz

@shopware-ag/meteor-admin-sdk

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@466

@shopware-ag/meteor-component-library

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@466

@shopware-ag/stylelint-plugin-meteor

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/stylelint-plugin-meteor@466

@shopware-ag/meteor-tokens

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@466

@shopware-ag/meteor-icon-kit

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@466

commit: f426c9d

@Haberkamp Haberkamp force-pushed the add-tests-for-banner branch from bd3b410 to 39c891f Compare January 21, 2025 14:07
alastair-simon
alastair-simon previously approved these changes Jan 21, 2025
@Haberkamp Haberkamp disabled auto-merge January 22, 2025 09:48
@Haberkamp Haberkamp merged commit 05d581e into main Jan 22, 2025
9 checks passed
@Haberkamp Haberkamp deleted the add-tests-for-banner branch January 22, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants