Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(component-library): update tsconfig to include jest-dom types #450

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

Haberkamp
Copy link
Contributor

What?

This PR add the types for the jest-dom matchers.

Why?

The types for the jest-dom matchers were missing. Typing .toBeInTheDocument resulted in an type-error.

How?

I updated the tsconfig so they no longer are overriting each other.

Testing?

Check out the branch and test it yourself

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-admin-sdk-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 9:15am
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 9:15am

Copy link

pkg-pr-new bot commented Jan 16, 2025

Open in Stackblitz

@shopware-ag/meteor-admin-sdk

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@450

@shopware-ag/meteor-component-library

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@450

@shopware-ag/stylelint-plugin-meteor

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/stylelint-plugin-meteor@450

@shopware-ag/meteor-tokens

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@450

@shopware-ag/meteor-icon-kit

npm i https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@450

commit: e4c94ad

@Haberkamp Haberkamp merged commit 293c0ce into main Jan 16, 2025
11 checks passed
@Haberkamp Haberkamp deleted the fix-missing-types-for-jest-dom branch January 16, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants