ci: increase timeout for acceptance tests to 40 minutes

.github/workflows/tests.yml

@@ -181,7 +181,7 @@ jobs:
 
   ats:
     name: Acceptance tests
-    timeout-minutes: 20
+    timeout-minutes: 45
     runs-on: ubuntu-latest
     needs:
       - circular-dependencies
@@ -262,18 +262,20 @@ jobs:
           pnpm install --frozen-lockfile --prefer-offline
           npx playwright install --with-deps
 
-      - name: Run Playwrigth
+      - name: Run playwright
         working-directory: meteor/examples/admin-sdk-plugin/tests/acceptance/
-        run: npx playwright test --retries=2 --reporter=github --trace=on-first-retry --project chromium
+        run: npx playwright test --reporter=github --trace=on --project chromium
 
-      - uses: actions/upload-artifact@v4
+      - run: ls -la
+        working-directory: meteor/examples/admin-sdk-plugin/tests/acceptance/
+        if: always()
+
+      - run: ls -la
+        working-directory: meteor/examples/admin-sdk-plugin/tests/acceptance/artifacts/
         if: always()
-        with:
-          name: ats-test-results-${{ matrix.project }}
-          path: meteor/examples/admin-sdk-plugin/tests/acceptance/test-results/
 
       - uses: actions/upload-artifact@v4
         if: always()
         with:
-          name: ats-report-${{ matrix.project }}
-          path: meteor/examples/admin-sdk-plugin/tests/acceptance/playwright-report/
+          name: ats-artifacts-${{ matrix.project }}
+          path: meteor/examples/admin-sdk-plugin/tests/acceptance/artifacts/

examples/admin-sdk-plugin/src/Resources/app/administration/package.json

@@ -13,7 +13,7 @@
     "@shopware-ag/meteor-admin-sdk": "workspace:*",
     "@shopware-ag/meteor-component-library": "workspace:*",
     "regenerator-runtime": "^0.14.1",
-    "vue": "^3.5.0",
+    "vue": "3.4.21",
     "vue-router": "4.4.5"
   },
   "devDependencies": {

examples/admin-sdk-plugin/tests/acceptance/tests/component-section.spec.ts

@@ -12,7 +12,7 @@ test.beforeEach(async ({ ShopAdmin, TestDataService, AdminProductDetail }) => {
 });
 
 test("@sdk: add a component section", async ({ ShopAdmin }) => {
-  await ShopAdmin.page.getByRole("link", { name: "Specifications" }).click();
+  await ShopAdmin.page.getByRole("tab", { name: "Specifications" }).click();
 
   await expect(
     ShopAdmin.page.locator(".sw-card__title", { hasText: "Location tests" }),
@@ -27,7 +27,7 @@ test("@sdk: add a component section", async ({ ShopAdmin }) => {
 });
 
 test("@sdk: add a component section with tabs", async ({ ShopAdmin }) => {
-  await ShopAdmin.page.getByRole("link", { name: "Specifications" }).click();
+  await ShopAdmin.page.getByRole("tab", { name: "Specifications" }).click();
 
   await expect(
     ShopAdmin.page.locator(".sw-card__title", { hasText: "Card tabs tests" }),

examples/admin-sdk-plugin/tests/acceptance/tests/location.spec.ts

@@ -16,7 +16,7 @@ test.beforeEach(async ({ ShopAdmin, TestDataService, AdminProductDetail }) => {
 test("@sdk: update the height of the location iFrame", async ({
   ShopAdmin,
 }) => {
-  await ShopAdmin.page.getByRole("link", { name: "Specifications" }).click();
+  await ShopAdmin.page.getByRole("tab", { name: "Specifications" }).click();
   await expect(
     ShopAdmin.page.locator(".sw-card__title", { hasText: "Location tests" }),
   ).toBeVisible();
@@ -40,7 +40,7 @@ test("@sdk: update the height of the location iFrame", async ({
 test("@sdk: start auto resizing of the iFrame height", async ({
   ShopAdmin,
 }) => {
-  await ShopAdmin.page.getByRole("link", { name: "Specifications" }).click();
+  await ShopAdmin.page.getByRole("tab", { name: "Specifications" }).click();
   await expect(
     ShopAdmin.page.locator(".sw-card__title", { hasText: "Location tests" }),
   ).toBeVisible();

examples/admin-sdk-plugin/tests/acceptance/tests/modals.spec.ts

@@ -12,7 +12,7 @@ test.beforeEach(async ({ ShopAdmin, TestDataService, AdminProductDetail }) => {
 });
 
 test("@sdk: modals", async ({ ShopAdmin }) => {
-  await ShopAdmin.page.getByRole("link", { name: "Example" }).click();
+  await ShopAdmin.page.getByRole("tab", { name: "Example" }).click();
   await expect(
     ShopAdmin.page.locator(".sw-card", { hasText: "Hello in the new tab" }),
   ).toBeVisible();

examples/admin-sdk-plugin/tests/acceptance/tests/tabs.spec.ts

@@ -12,7 +12,7 @@ test.beforeEach(async ({ ShopAdmin, TestDataService, AdminProductDetail }) => {
 });
 
 test("@sdk: Check tab existence", async ({ ShopAdmin }) => {
-  await ShopAdmin.page.getByRole("link", { name: "Example" }).click();
+  await ShopAdmin.page.getByRole("tab", { name: "Example" }).click();
   await expect(
     ShopAdmin.page.locator(".sw-card", { hasText: "Hello in the new tab" }),
   ).toBeVisible();

packages/component-library/src/components/table-and-list/mt-data-table/sub-components/mt-data-table-settings/mt-data-table-settings.vue

@@ -234,7 +234,7 @@ export default defineComponent({
         return {
           id: column.property,
           label: column.label,
-          parentGroup: column.visible ?? true ? "visible" : "hidden",
+          parentGroup: (column.visible ?? true) ? "visible" : "hidden",
           position: column.position,
           isVisible: column.visible ?? true,
           isHidable: isPrimaryColumn(column) ? false : true,