feat: re-export MtSearch in dist #248
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Haberkamp
force-pushed
the
fix/hub-202-export-mt-search
branch
from
945b2be to
e41b3a5
Compare
| @@ -20,6 +20,8 @@ | |||
| </MtText> | |||
|
|
|||
| <SwTextField label="A text field" v-model="text" /> | |||
|
|
|||
| <MtSearch /> | |||
There was a problem hiding this comment.
I think just making the mt-search component public is enough. We don't need to use every single component in the nuxt example app.
There was a problem hiding this comment.
mt-search does depend on the $t which is provided here. Though this isn't correct solution (using correct Vue/Nuxt i18n library would be the right approach), we do have an "example app" where we can show that the component actually depends on the i18n library.
| "nuxt-app": patch | ||
| --- | ||
|
|
||
| Re-export mt-search and reuse it in nuxt-app example |
There was a problem hiding this comment.
Please only include what's relevant for users of the component library. They just care about the mt-search component but not wether the component is used inside the nuxt example app.
|
Closing in favour of #475 |
What?
Re-export
MtSearchcomponent.Why?
So we (and everyone else) can re-use it.
How?
Testing?
Screenshots (optional)
Anything Else?