feat(docs): add combined docs for paypal #1641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mstegmeyer
requested changes
Jan 24, 2025
| orderCreated.value = await createOrder({ | ||
| paypalOrderId: data.orderID, | ||
| // optional - can be acdc, applepay, googlepay or venmo | ||
| product: 'sbp', |
There was a problem hiding this comment.
spb, not sbp ;)
Also, please document which product for which payment method, since it may be important, because different paymentSources get filled.
Comment on lines
+208
to
+210
| orderId: orderCreated.value.id, | ||
| successUrl: `${window.location.origin}/order/success?order=${orderCreated.value.id}&success=true`, | ||
| errorUrl: `${window.location.origin}/order/success?order=${orderCreated.value.id}&success=false`, |
There was a problem hiding this comment.
doesn't that need the paypalOrderId to capture the created order? Same below in the existing example, I believe this was always an issue that this was not documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current documentation on integrating PayPal only covers Express Checkout. Therefore, we would like to adapt the existing documentation to cover both a standard PayPal checkout and an express checkout.
Type of change
Tweak the existing documentation, as most of it is generic for a PayPal checkout anyway, and add some dedicated sections for the express case.
ToDo's
Currently, the different sections for standard and express checkout are duplicated. Perhaps there is a better way to structure this?