Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move vue-demo-store to biome #1506

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Dec 3, 2024

switched vue-demo-store package linting to biome for better accuracy and performance
test: time pnpm run lint inside package

before

pnpm run lint  22.16s user 2.47s system 151% cpu 16.283 total

after

pnpm run lint  0.43s user 0.07s system 118% cpu 0.416 total

apart of the speed it was more accurate in finding problems and making the code more consistent

@patzick patzick requested a review from mkucmus December 3, 2024 16:30
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Dec 3, 2024 4:49pm
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Dec 3, 2024 4:49pm

Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #1506 will not alter performance

Comparing feat/move-vue-demo-store-to-biome (97291e2) with main (a965e10)

Summary

✅ 9 untouched benchmarks

@patzick
Copy link
Collaborator Author

patzick commented Dec 3, 2024

sidenote: needed to move biome back to 1.8.3 and turn off IDE plugin until biomejs/biome#4684 is resolved. As that causes problem in shopware.d.ts files

Copy link

pkg-pr-new bot commented Dec 3, 2024

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1506

@shopware-pwa/cms-base

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/cms-base@1506

@shopware-pwa/composables-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/composables-next@1506

@shopware-pwa/helpers-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/helpers-next@1506

@shopware-pwa/nuxt3-module

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/nuxt3-module@1506

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1506

commit: 97291e2

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 pnpm run lint 0.43s user 0.07s system 118% cpu 0.416 total why not 0.1s ? 😄

@patzick patzick merged commit 0d426c2 into main Dec 3, 2024
14 checks passed
@patzick patzick deleted the feat/move-vue-demo-store-to-biome branch December 3, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants