feat(composable): add useMedia composable #1370
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@shopware/api-client
@shopware/api-gen
@shopware-pwa/cms-base
@shopware-pwa/composables-next
@shopware-pwa/helpers-next
@shopware-pwa/nuxt3-module
commit: |
pnpm-lock.yaml
Outdated
There was a problem hiding this comment.
pnpm-lock.yaml changes needed? 🤔
| * | ||
| * @returns {UseMedia} media composable | ||
| */ | ||
| export function useMedia(): UseMedia { |
There was a problem hiding this comment.
I would like to see what kind of media this composable is made for. Maybe we could add a parameter in type Media for composable function, and then we could extract ids from argument and replace/merge it with ids provided in fetchMedia function which could then become optional.
the second option to tell something more about the purpose is providing an example in functions' description and changeset file.
| import { useShopwareContext } from "#imports"; | ||
| import type { operations } from "#shopware"; | ||
|
|
||
| interface UseMedia { |
There was a problem hiding this comment.
it's our first interface within composables, maybe we could keep it consistent and change to the type 😉
vercel
bot
temporarily deployed
to
Preview – shopware-frontends-docs
Description
Add useMedia composable
Type of change
ToDo's
Screenshots (if applicable)
Additional context