Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(composables): add 100% coverage #1131

Merged
merged 19 commits into from
Jul 27, 2024
Merged

feat(composables): add 100% coverage #1131

merged 19 commits into from
Jul 27, 2024

Conversation

mdanilowicz
Copy link
Collaborator

Description

Type of change

ToDo's

Screenshots (if applicable)

Additional context

@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Jul 26, 2024 1:31pm
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jul 26, 2024 1:31pm

@mdanilowicz mdanilowicz marked this pull request as draft July 18, 2024 10:53
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 18, 2024

CodSpeed Performance Report

Merging #1131 will not alter performance

Comparing feat/composable-tests-ii (0689926) with main (db7c93f)

Summary

✅ 9 untouched benchmarks

@mdanilowicz mdanilowicz changed the title feat: more tests feat(composables): add 100% coverage Jul 24, 2024
@mdanilowicz mdanilowicz marked this pull request as ready for review July 24, 2024 08:18
patzick
patzick requested changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🙌 I reviewed the code and left some comments. Mainly to make test names more descriptive. People should not need to read the test code tested code to understand what the test is doing. This way, we also have proper documentation for the tested code.

While applying suggestions, please make sure that:

  • test names are properly documenting features/behaviours of the code
  • mocks are cleared between tests, so there is no impact between singular tests
  • fill the PR description appropriately so when someone looks at this PR in the future description summarizes what's changed here

packages/composables/src/index.test.ts Outdated Show resolved Hide resolved
packages/composables/src/index.test.ts Outdated Show resolved Hide resolved
packages/composables/src/useCart.test.ts Show resolved Hide resolved
packages/composables/src/useCart.test.ts Outdated Show resolved Hide resolved
packages/composables/src/useCartItem.test.ts Outdated Show resolved Hide resolved
packages/composables/src/useProductAssociations.spec.ts Outdated Show resolved Hide resolved
packages/composables/src/useProductPrice.test.ts Outdated Show resolved Hide resolved
packages/composables/vitest.config.ts Outdated Show resolved Hide resolved
packages/composables/vitest.config.ts Outdated Show resolved Hide resolved
packages/composables/src/_test/useSetup.ts Outdated Show resolved Hide resolved
@patzick patzick merged commit e36725d into main Jul 27, 2024
8 of 9 checks passed
@patzick patzick deleted the feat/composable-tests-ii branch July 27, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkucmus mkucmus mkucmus left review comments

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdanilowicz @mkucmus @patzick