Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: eslint upgrade #1089

Merged
merged 36 commits into from
Jul 18, 2024
Merged

feat: eslint upgrade #1089

merged 36 commits into from
Jul 18, 2024

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Jul 4, 2024 •
edited
Loading

Description

upgrades eslint to the latest version with BC's

additionally:

  • cms-base package is now under recommended setup for vue
  • adds export for cjs and mjs
  • shares a common config that can be extended
  • applies new lint for cms-base package

Type of change

New feature (non-breaking change which adds functionality)

ToDo's

Screenshots (if applicable)

Additional context

@vercel Vercel
Copy link

vercel bot commented Jul 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Jul 18, 2024 10:34am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jul 18, 2024 10:34am

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 4, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1089 will not alter performance

Comparing feat/eslint-upgrade (83bf28b) with main (d4c4e8a)

Summary

✅ 9 untouched benchmarks

@mkucmus mkucmus marked this pull request as ready for review July 17, 2024 10:43
@mkucmus mkucmus requested a review from patzick July 17, 2024 10:43
patzick
patzick reviewed Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can already see improvements in code quality enforced by the upgrade 💪

Haven't tested it yet locally, just reviewed files now and leaving few notes

.changeset/chilled-cars-lick.md Outdated Show resolved Hide resolved
.github/workflows/code-check.yml Outdated Show resolved Hide resolved
packages/api-gen/package.json Outdated Show resolved Hide resolved
packages/cms-base/package.json Outdated Show resolved Hide resolved
packages/cms-base/eslint.config.mjs Outdated Show resolved Hide resolved
packages/eslint-config-shopware/package.json Outdated Show resolved Hide resolved
@mkucmus mkucmus requested a review from patzick July 18, 2024 07:11
patzick
patzick approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 🐛 ❌ 👍

@patzick patzick merged commit db7c93f into main Jul 18, 2024
13 checks passed
@patzick patzick deleted the feat/eslint-upgrade branch July 18, 2024 10:41
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkucmus @patzick