Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(composables): load shipping address association #1074

Merged
merged 25 commits into from
Jul 17, 2024
Merged

fix(composables): load shipping address association #1074

merged 25 commits into from
Jul 17, 2024

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Jul 1, 2024 •
edited
Loading

Description

  • vue-demo-store: Fixes missing order status and missing shipping address at the order success page
  • api-gen: takes care of translated properties and their format in output .d.ts files
  • all: removes optional chaining for translated object and its properties

Type of change

Bug fix (non-breaking change that fixes an issue)

ToDo's

Screenshots (if applicable)

Additional context

@vercel Vercel
Copy link

vercel bot commented Jul 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Jul 17, 2024 9:34am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jul 17, 2024 9:34am

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 1, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1074 will not alter performance

Comparing fix/missing-address-and-order-status (a040b2d) with fix/missing-address-and-order-status (3a6623b)

Summary

✅ 9 untouched benchmarks

@mkucmus mkucmus requested a review from kstala July 1, 2024 10:58
@mkucmus mkucmus requested a review from patzick July 15, 2024 20:25
@mkucmus
Copy link
Collaborator Author

mkucmus commented Jul 15, 2024

@kstala if you don't mind, please retest this PR, but now check also the translated strings coming from API, like names, descriptions, breadcrumbs, etc..

patzick
patzick requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, just few small things to polish it 💅

.changeset/afraid-keys-hear.md Outdated Show resolved Hide resolved
.changeset/early-trains-run.md Outdated Show resolved Hide resolved
.changeset/funny-onions-call.md Outdated Show resolved Hide resolved
.changeset/sour-starfishes-hide.md Outdated Show resolved Hide resolved
packages/api-client/api-types/storeApiTypes.d.ts Show resolved Hide resolved
packages/api-gen/src/commands/generate.ts Outdated Show resolved Hide resolved
mkucmus and others added 2 commits July 17, 2024 11:00
@mkucmus mkucmus requested a review from patzick July 17, 2024 09:10
@mkucmus
Copy link
Collaborator Author

mkucmus commented Jul 17, 2024 •
edited
Loading

since now on, we access for translated and not translated values for properties using translated object, which also contain a fallback value if there is no translation. More info here.

patzick
patzick approved these changes Jul 17, 2024
View reviewed changes
.changeset/early-trains-run.md Outdated Show resolved Hide resolved
.changeset/afraid-keys-hear.md Outdated Show resolved Hide resolved
@patzick patzick merged commit b688163 into main Jul 17, 2024
11 checks passed
@patzick patzick deleted the fix/missing-address-and-order-status branch July 17, 2024 09:38
@github-actions github-actions bot mentioned this pull request Jul 17, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdanilowicz mdanilowicz mdanilowicz requested changes

@patzick patzick patzick approved these changes

@kstala kstala Awaiting requested review from kstala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkucmus @mdanilowicz @patzick @kstala