NEXT-39768 - Added a listener to stop the Shop registration process if the Shop URL is not reachable #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f he URL is not reachable
…pass and moved to the service.xml
nsaliu
force-pushed
the
next-39769/add-event-listener-to-stop-the-registration-if-the-url-is-not-reachable
branch
from
c330b95 to
69ac305
Compare
shyim
reviewed
Nov 28, 2024
buzyka
reviewed
Nov 28, 2024
…added test for custom exception.
|
This PR must be merged only after shopware/app-php-sdk#28 |
buzyka
approved these changes
Dec 3, 2024
shyim
deleted the
next-39769/add-event-listener-to-stop-the-registration-if-the-url-is-not-reachable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
BeforeRegistrationStartsListenersubscribed to theBeforeRegistrationStartsEventevent triggered by theapp-php-sdkthat prevents the Shop from being registered if the Shop URL is not reachable from the internet.If the value of
check_if_shop_url_is_reachableistrue, then the check will take place, and an exception will be thrown; otherwise, nothing will happen.