Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shop url sanitization #49

Closed
wants to merge 2 commits into from
Closed

Shop url sanitization #49

wants to merge 2 commits into from

Conversation

nsaliu
Copy link
Contributor

@nsaliu nsaliu commented Nov 8, 2024

The Shop url needs to be sanitized to remove the trailing slash.

@nsaliu nsaliu self-assigned this Nov 8, 2024
@nsaliu nsaliu requested review from shyim and SimonVorgers November 8, 2024 16:07
@shyim
Copy link
Member

shyim commented Nov 11, 2024

this should be done in the app php sdk and while registration, so the data in the database is correct

@nsaliu
Copy link
Contributor Author

nsaliu commented Nov 11, 2024

I am closing this PR in favor of dedicated activity.

@nsaliu nsaliu closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants