Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Convert to TypeScript #878

Merged
merged 11 commits into from
Apr 10, 2024
Merged

Convert to TypeScript #878

merged 11 commits into from
Apr 10, 2024

Conversation

charlesfries
Copy link
Contributor

  • Convert addon to TypeScript
  • Support Glint

@charlesfries charlesfries mentioned this pull request Jan 26, 2024
Closed
@RobbieTheWagner
Copy link
Member

Thanks for the PR @charlesfries! Would you be interested in finishing it up or would you like some help?

@charlesfries
Merge branch 'main' into ts
c14c0bf 
# Conflicts:
#	package.json
#	tests/acceptance/code-block-test.ts
#	yarn.lock
@charlesfries
Lock
2c73816
@charlesfries
Lint
86ba2b5
@charlesfries
Add prismjs-glimmer local types
21f5445
@charlesfries
Copy link
Contributor Author

Thanks @RobbieTheWagner, it should be good now. The only minor annoyance is the usage of declare const Prism: any;; I tried installing @types/prismjs and then importing Prism from prismjs but that seems to slightly change the padding of the code blocks on the test app.

Not sure what the deal is there but I just left the globals in and added that line.

@charlesfries charlesfries marked this pull request as ready for review April 10, 2024 17:52
@RobbieTheWagner
Copy link
Member

LGTM, thanks for the PR!

@RobbieTheWagner RobbieTheWagner merged commit f408fcf into shipshapecode:main Apr 10, 2024
10 checks passed
@charlesfries charlesfries deleted the ts branch April 10, 2024 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesfries @RobbieTheWagner