Skip to content

Commit

Permalink
Upload reports
Browse files Browse the repository at this point in the history
  • Loading branch information
sherlock-admin committed Dec 10, 2024
1 parent e0decad commit f73b8dc
Show file tree
Hide file tree
Showing 2 changed files with 92 additions and 0 deletions.
Binary file added Audit_Report.pdf
Binary file not shown.
92 changes: 92 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,16 @@ None

Use the `quoteSwap` function to calculate how much needs to be swapped until the target price is hit.



## Discussion

**sherlock-admin2**

The protocol team fixed this issue in the following PRs/commits:
https://github.com/AXION-MONEY/liquidity-amo/pull/7


# Issue H-2: V2AMO is not compatible with Velodrome/Aerodrome.

Source: https://github.com/sherlock-audit/2024-10-axion-judging/issues/239
Expand Down Expand Up @@ -188,6 +198,16 @@ N/A

N/A



## Discussion

**sherlock-admin2**

The protocol team fixed this issue in the following PRs/commits:
https://github.com/AXION-MONEY/liquidity-amo/pull/9


# Issue H-3: V3AMO integration with V3 does not collect LP fees when burning liquidity.

Source: https://github.com/sherlock-audit/2024-10-axion-judging/issues/242
Expand Down Expand Up @@ -352,6 +372,16 @@ N/A

Add a function to call the `RewardsDistributor.sol` for SolidlyV3 to retrieve the LP fees. This can be an independent function, since not all SolidlyV3 forks may support this feature.



## Discussion

**sherlock-admin2**

The protocol team fixed this issue in the following PRs/commits:
https://github.com/AXION-MONEY/liquidity-amo/pull/10


# Issue H-4: Liquidity is incorrectly calculated during `addLiquidity()` for V3AMO, causing DoS.

Source: https://github.com/sherlock-audit/2024-10-axion-judging/issues/280
Expand Down Expand Up @@ -506,6 +536,16 @@ Use the UniswapV3 library for calculating liquidity: https://github.com/Uniswap/
```



## Discussion

**sherlock-admin2**

The protocol team fixed this issue in the following PRs/commits:
https://github.com/AXION-MONEY/liquidity-amo/pull/12


# Issue M-1: Boost can be sold under peg despite comments and code attempting to prevent it

Source: https://github.com/sherlock-audit/2024-10-axion-judging/issues/36
Expand Down Expand Up @@ -568,6 +608,16 @@ Not required according to the terms

Check that you can only sell to the sqrt K 1:1 balanced price.



## Discussion

**sherlock-admin2**

The protocol team fixed this issue in the following PRs/commits:
https://github.com/AXION-MONEY/liquidity-amo/pull/4


# Issue M-2: V2AMO and V3AMO: USDT Approval Logic Causes Reversion

Source: https://github.com/sherlock-audit/2024-10-axion-judging/issues/47
Expand Down Expand Up @@ -682,10 +732,22 @@ Adding liquidity and farming will fail due to a revert on USDT approvals

Use `safeApprove` instead of `approve`



## Discussion

**sherlock-admin2**

The protocol team fixed this issue in the following PRs/commits:
https://github.com/AXION-MONEY/liquidity-amo/pull/5


# Issue M-3: Contracts of the codebase will not strictly compliant with the ERC-1504.

Source: https://github.com/sherlock-audit/2024-10-axion-judging/issues/155

The protocol has acknowledged this issue.

## Found by
0xnbvc, Atharv, AuditorPraise, HackTrace, Kirkeelee, dany.armstrong90, isagixyz, pkqs90
### Summary
Expand Down Expand Up @@ -814,6 +876,16 @@ it("Showcases the incorrect price that is returned", async function() {

_No response_



## Discussion

**sherlock-admin2**

The protocol team fixed this issue in the following PRs/commits:
https://github.com/AXION-MONEY/liquidity-amo/pull/8


# Issue M-5: MasterAMO should not use the `initializer` modifier

Source: https://github.com/sherlock-audit/2024-10-axion-judging/issues/244
Expand Down Expand Up @@ -882,6 +954,16 @@ Replace the initializer modifier in the [MasterAMO](https://github.com/sherlock-
+ ) public onlyInitializing {
```



## Discussion

**sherlock-admin2**

The protocol team fixed this issue in the following PRs/commits:
https://github.com/AXION-MONEY/liquidity-amo/pull/11


# Issue M-6: The `V3AMO._mintAndSellBoost()` function does not work with Velodrome, Aerodrome, Fenix, Thena and Ramses

Source: https://github.com/sherlock-audit/2024-10-axion-judging/issues/268
Expand Down Expand Up @@ -958,3 +1040,13 @@ Protocol team can't mint additional `BOOST` and sell them for `USDC` to bring th

Use the correct function parameters for Velodrome, Aerodrome, Fenix, Thena and Ramses.



## Discussion

**sherlock-admin2**

The protocol team fixed this issue in the following PRs/commits:
https://github.com/AXION-MONEY/liquidity-amo/pull/13


0 comments on commit f73b8dc

Please sign in to comment.