Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database verison parsing #1222

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix database verison parsing #1222

merged 1 commit into from
Jan 10, 2025

Conversation

Awesomerly
Copy link
Contributor

In the "DoWeHaveWindowFunctions" function, the timer checks the version numbers by converting it to a float. For some reason, this didn't work for me because sVersion was 10.11.6-MariaDB-0+deb12u1, then StringToFloat converted that into 10.109999, which isn't greater than the required version of 10.2!

I changed this function to parse the major and minor version and do integer comparisons instead. I haven't tested it thoroughly but it seems to work.

@rtldg
Copy link
Collaborator

rtldg commented Jan 10, 2025

Good catch. It looks like it'll work so a yolo-merge for this too

@rtldg rtldg merged commit ab75ef4 into shavitush:master Jan 10, 2025
3 checks passed
@Awesomerly Awesomerly deleted the thegame branch January 10, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants