Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS-337: Create is-alive + stubbed out is-healthy endpoints #50

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

chrypnotoad
Copy link
Contributor

@chrypnotoad chrypnotoad commented Aug 1, 2024

This pull request adds two new endpoints, /is-alive and /is-healthy, to the existing API. The /is-alive endpoint returns a 200 status code if the server is running, while the /is-healthy endpoint will be expanded in the future.

  • adds /is-alive
  • adds /is-healthy
  • existing /api/health endpoint was removed (I did not find a reference to it in any of our other repos)

changes unrelated to the ticket:

  • fixed local_tests.patch not applying
  • prettier formatting
  • fixed npm format-fix and format-check so they work on windows as well as mac/linux

Copy link

github-actions bot commented Aug 1, 2024

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Placeholder Logic
The '/is-healthy' endpoint currently has a placeholder comment and returns a 200 status without any actual health check logic. This needs to be implemented or flagged for future implementation.

Copy link

@paulgs9988 paulgs9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to ask here for future documentnation:

Are any of the CI checks merge-blocking?

@chrypnotoad chrypnotoad requested a review from BelfordZ August 1, 2024 21:12
@chrypnotoad
Copy link
Contributor Author

Want to ask here for future documentnation:

Are any of the CI checks merge-blocking?

format check and unit tests failing will not block yet the other stages will (build, lint, apply patches)

prettier

fix npm format for windows

fix local test patch

change to sendStatus
@mhanson-github mhanson-github merged commit d799a64 into dev Aug 9, 2024
7 checks passed
@mhanson-github mhanson-github deleted the SYS-337-is-alive branch August 30, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants