SHARD-1708: Add network account listOfChanges update script #126
+191
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling in GlobalAccount
S0naliThakur
requested review from
aniketdivekar,
urnotsam,
jintukumardas and
afostr
| } | ||
|
|
||
| // Utility function to validate and parse input based on expected type | ||
| const parseInput = (value: string, expectedType: string, defaultValue: any): any => { |
There was a problem hiding this comment.
I am not sure how I feel about assigning a defaultValue. If we're using this code to overwrite the network account, I somewhat feel that there should only be intentional and explicit changes.
There was a problem hiding this comment.
Clarifying... the question is should we treat the results differently if we ended up with value or defaultValue?
| console.log('❌ Changes were not applied.') | ||
| } | ||
|
|
||
| await dbstore.closeDatabase() |
There was a problem hiding this comment.
Should we have a try/finally setup here to ensure DB closure?
urnotsam
previously approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/shm/issue/SHARD-1708
Summary: Add network account listOfChanges update script