Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARD-1166: Archiver whitelisting #123

Merged
merged 13 commits into from
Jan 24, 2025
Merged

SHARD-1166: Archiver whitelisting #123

merged 13 commits into from
Jan 24, 2025

Conversation

jintukumardas
Copy link
Contributor

Use the signed list of allowed archivers.

@jintukumardas jintukumardas self-assigned this Jan 3, 2025
src/API.ts Fixed Show fixed Hide fixed
allowed-archivers.json Outdated Show resolved Hide resolved
src/API.ts Outdated Show resolved Hide resolved
src/API.ts Fixed Show fixed Hide fixed
src/API.ts Fixed Show fixed Hide fixed
@jintukumardas jintukumardas changed the title [DRAFT] SHARD-1166: Archiver whitelisting SHARD-1166: Archiver whitelisting Jan 8, 2025
src/API.ts Outdated Show resolved Hide resolved
src/API.ts Outdated Show resolved Hide resolved
@abdulazeem-tk4vr abdulazeem-tk4vr self-requested a review January 13, 2025 10:00
@@ -1296,19 +1314,32 @@
Logger.mainLogger.error('Data sender publicKey and sign owner key does not match')
return { success: false, error: 'Data sender publicKey and sign owner key does not match' }
}
if (!Crypto.verify(data)) {
Logger.mainLogger.error('Invalid signature', data)

Check warning

Code scanning / CodeQL

Log injection Medium

Log entry depends on a
user-provided value
.
Log entry depends on a
user-provided value
.
Log entry depends on a
user-provided value
.
Log entry depends on a
user-provided value
.
Log entry depends on a
user-provided value
.
Log entry depends on a
user-provided value
.
@jintukumardas jintukumardas changed the title SHARD-1166: Archiver whitelisting [DRAFT] SHARD-1166: Archiver whitelisting Jan 14, 2025
@jintukumardas jintukumardas changed the title [DRAFT] SHARD-1166: Archiver whitelisting SHARD-1166: Archiver whitelisting Jan 16, 2025
"publicKey": "e8a5c26b9e2c3c31eb7c7d73eaed9484374c16d983ce95f3ab18a62521964a94"
}
],
"allowedAccounts": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets remove this and also minSigRequired

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jintukumardas this is still pending

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary for the initial config load, as the Global account data will initially be empty. This data will serve as a reference, but once we receive the Global account data, it will no longer be needed/referenced.

src/shardeum/allowedArchiversManager.ts Show resolved Hide resolved
src/shardeum/allowedArchiversManager.ts Show resolved Hide resolved
aniketdivekar
aniketdivekar previously approved these changes Jan 23, 2025
@aniketdivekar aniketdivekar merged commit 55df324 into dev Jan 24, 2025
6 of 7 checks passed
@aniketdivekar aniketdivekar deleted the SHARD-1166 branch January 24, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants