feat: lifi swapper simplify status detection

[gomesalexandre]

Description

Or well, not exactly. More like being consistent with CoW and Chainflip by early returning on seen Txs - in effect, should be a no-op for the specific case of Li.Fi.

Issue (if applicable)

closes #8534

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low - seemingly a change of heuristics (early return on seen Tx vs. waiting for "DONE" status), though, in effect, both are true at the exact same time.

Testing

• Li.Fi status detection is still happy

Engineering

• ^

Operations

• 🏁 My feature is behind a flag and doesn't require operations testing (yet)

• ^

Screenshots (if applicable)

https://jam.dev/c/67cdc603-08f1-4321-a648-e20439cc514d

[0xApotheosis]

Does what it says on the box!

One suggestion to make this more concise, if you're so inclined...

diff --git a/packages/swapper/src/swappers/LifiSwapper/endpoints.ts b/packages/swapper/src/swappers/LifiSwapper/endpoints.ts
index b5fd94a03d..b9d1a14304 100644
--- a/packages/swapper/src/swappers/LifiSwapper/endpoints.ts
+++ b/packages/swapper/src/swappers/LifiSwapper/endpoints.ts
@@ -286,15 +286,7 @@ export const lifiApi: SwapperApi = {
     if (!response.ok) return createDefaultStatusResponse()

     const statusResponse = await response.json()
-
-    // We have an out Tx hash (either same or cross-chain) for this step, so we consider the Tx (effectively, the step) confirmed
-    if ((statusResponse.receiving as ExtendedTransactionInfo)?.txHash) {
-      return {
-        status: TxStatus.Confirmed,
-        buyTxHash: (statusResponse.receiving as ExtendedTransactionInfo).txHash,
-        message: statusResponse.substatusMessage,
-      }
-    }
+    const receiving: ExtendedTransactionInfo | undefined = statusResponse.receiving

     const status = (() => {
       switch (statusResponse.status) {
@@ -308,8 +300,8 @@ export const lifiApi: SwapperApi = {
     })()

     return {
-      status,
-      buyTxHash: (statusResponse.receiving as ExtendedTransactionInfo)?.txHash,
+      status: receiving?.txHash ? TxStatus.Confirmed : status,
+      buyTxHash: receiving?.txHash,
       message: statusResponse.substatusMessage,
     }
   },

[gomesalexandre]

One suggestion to make this more concise, if you're so inclined...

Absolutely @0xApotheosis ! Tackled in d63aa56 and retested: https://jam.dev/c/9c07f48b-9e24-4637-ad60-c4e858d38f7f