fix: jupiter more accurate price impact #8566
Merged
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jupiter price impact was around 1% but the API provide us the real price impact directly
For this I introduced a new prop to the quote so we can provide the price impact directly to
usePriceImpact
without doing some handmade mathsSometimes it shows
0
because it's very small, I think it's acceptable as it clearly says that the impact is very small, but we might want to ask product how it should behave in that particular case? I don't want to add 4 decimals to all the amountsIssue (if applicable)
Spotted while fixing #8556
Risk
Low
Testing
Engineering
n/a
Operations
n/a
Screenshots (if applicable)