Rewrite hub.js and add task dependencies. #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha this is nuts (in a good way). I like how you made the |
|
Hey, have you been able to take a look at this? |
|
👍 Nice PR! |
|
Bump. :) |
|
has this project stalled? |
|
Sorry, just a big change that I haven't gotten a chance to fully review yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shama, here's the PR for #47.
What this changes:
dependencyFnoption. (Default: no dependencies)bufferOutputoption to only print output from a task once it completes. (Default:false)concurrentoption (temporarily--can be re-added once newly opened Add concurrency argument to async.auto caolan/async#637 is merged) due to switch fromasync.queuetoasync.auto.I know it's a lot for one Pull Request. If you'd prefer, I can spend some more time breaking it up, but I figured it might save you time if it were just once batch.
Also, I apologize that there are so many refactorings mixed in. :/ I kinda went crazy, and if you'd like I can undo some of them.
Let me know what you think.