Change checkrule as per the created ruleset #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naphann
approved these changes
May 23, 2024
There was a problem hiding this comment.
Looks good to me. This closes #552.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @zigen)
zigen
approved these changes
May 24, 2024
Naphann
reviewed
May 27, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @lmpawan10)
Naphann
approved these changes
May 27, 2024
There was a problem hiding this comment.
@lmpawan10 You seem to be holding up the check, any comments you're still not satisfied?
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @lmpawan10)
lmpawan10
commented
May 27, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lmpawan10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes have been made inside HardwareMonitor.cc, purification_type 1031:
DOUBLE_SELECTION_X_PURIFICATION changed to DOUBLE_SELECTION_XZ_PURIFICATION
DOUBLE_SELECTION_Z_PURIFICATION changed to DOUBLE_SELECTION_ZX_PURIFICATION
This change is