-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed basis from char to enum #522
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for contribution!
could you check my comment and fix, commit and push it again?
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MadhuMPandurangi)
quisp/modules/QNIC/StationaryQubit/StationaryQubit.cc
line 253 at r1 (raw file):
if (rand < 1.0 / 3) { outcome.outcome_is_plus = qubit_ref->measureX() == EigenvalueResult::PLUS_ONE; outcome.basis = backends::abstract::Basis::X;
you can declare using backends::abstract::Basis
on top of the .cc file, and use it like Basis::X
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and clang-format step is failed, could you run $ make format
to format your code?
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MadhuMPandurangi)
Declaring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MadhuMPandurangi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MadhuMPandurangi)
This is the test result. Shows successfully passed all test cases. This PR is regarding Issue #476
`[----------] Global test environment tear-down
[==========] 183 tests from 31 test suites ran. (969 ms total)
[ PASSED ] 183 tests.
make[1]: Leaving directory '/workspaces/quisp/quisp'`
This change is