Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix CI by pinning to the Ubuntu 22.04 image #2357

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

alex
Copy link
Collaborator

@alex alex commented Jan 31, 2025

No description provided.

@botovq
Copy link
Contributor

botovq commented Jan 31, 2025

Thanks.

While this will most likely fix CI, some of the failures I saw suggest that rust-openssl has actual problems on arm platforms on newer ubuntu:

This here is one of them related to time_t:

https://github.com/sfackler/rust-openssl/actions/runs/13067958829/job/36463478280

and this one is downright scary since it suggests that on very old OpenSSL releases, rust-openssl and C disagree about the struct layout of X509_VERIFY_PARAM:

https://github.com/sfackler/rust-openssl/actions/runs/13067958829/job/36463480631

Now it is unlikely that many people will use such an OpenSSL on ubuntu 24.04, but you never know.

@alex
Copy link
Collaborator Author

alex commented Jan 31, 2025

Yes, there's a real substantive problem here: Ubuntu 24.04 for armhf has a 64-bit time_t, and the libc crate does not know about this: rust-lang/libc#3223

I don't think it's something we're in a position to mitigate ourselves, frustratingly.

@alex alex requested a review from sfackler January 31, 2025 15:47
@sfackler
Copy link
Owner

Sounds like it's time to jettison support for 1.0.x?

@sfackler sfackler merged commit 4f11354 into sfackler:master Jan 31, 2025
67 checks passed
@alex
Copy link
Collaborator Author

alex commented Jan 31, 2025

That'd ameliorate a lot of the problem! https://endoflife.date/openssl indicates you can pay OpenSSL to still support it, but no one is paying me!

@alex alex deleted the fix-ci branch January 31, 2025 21:48
@botovq
Copy link
Contributor

botovq commented Jan 31, 2025

Yes, that makes sense and seems the right move given these problems. FWIW, ruby/openssl dropped support for 1.0.x and 1.1.0 (and all unmaintained libressl versions) a few weeks ago: ruby/openssl#835

@sfackler
Copy link
Owner

We could add a sizeof(time_t) to expando.c to try to pick the right size for that field, but that assumes the build and runtime hosts made the same choice here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants