Fix rolling restart 1.0.3 #317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move Contributors to separate file.
Change pidfile handling, always add index to pidfile name
Respect both local and global puma_user setting everywhere
Fixes identation and Increase documentation with info about :sidekiq_config
update sidekiq dependency
This handles the case where any of the steps in the deploy process after quieting sidekiq fail, e.g. pulling from git, compiling assets, etc. For cap v2, this is documented here: https://github.com/leehambley/capistrano-handbook/blob/master/index.markdown#transactions For cap v3, the pull request adding support is here: capistrano/capistrano#756. I think this was the intention of seuros#105.
Ben's version bump
This configuration option can be set with successful results but was undocumented.
Documenting sidekiq_service_name config option
Add missing monit default config options to README
Make sidekiq:stop task perpetually callable
add documentation; add note to ensure shared/tmp/pids folder exists i…
Use new capistrano DSL for reenable tasks
Convert CHANGELOG to Markdown + Add Unreleased Section
…pistrano-sidekiq into phillbaker-add-deploy-failure
…into zocoi-master
- Minor corrections suggested by Rubocop
Corrected the following infractions:
- [Style/PercentLiteralDelimiters](http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/PercentLiteralDelimiters)
- [Lint/UnusedBlockArgument](http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/UnusedBlockArgument)
- [Style/Next](http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/Next)
- [Style/IfUnlessModifier](http://www.rubydoc.info/gems/rubocop/0.9.1/Rubocop/Cop/Style/IfUnlessModifier)
- [Lint/UnderscorePrefixedVariableName](http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/UnderscorePrefixedVariableName)
- [Style/UnneededInterpolation](http://www.rubydoc.info/github/bbatsov/RuboCop/RuboCop/Cop/Style/UnneededInterpolation)
- [Performance/RedundantBlockCall](http://www.rubydoc.info/github/bbatsov/RuboCop/RuboCop/Cop/Performance/RedundantBlockCall)
- [Layout/MultilineOperationIndentation](http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Layout/MultilineOperationIndentation)
- Updated CHANGELOG.md to include recent bugfixes and 1.0.0 (forgotten) breaking changes
…ing_accounted_correctly Fix accounting of pidfiles per process (when using multiple processes)
fix fail rolling restart task
1.sidekiq_service_name cann't fetch application at initialization phase.So use block. 2.replace fetch(:sidekiq_monit_group, fetch(:application) with fetch(:sidekiq_monit_group) || fetch(:application)
…-name-missing-application Fix monit config file name missing application
Without adjusting the process number the configured second queue will never be started.
Update README#Multiple processes example
Point readers towards enable lingering for systemd
close seuros#223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from #316
I created a PR to v1 branch to update last version of v1(1.0.3).
If you create another branch for v1, I'll change the base branch of my PR.
Thanks.