Add support for illumos #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, ipc-channel works and the full test suite passes on illumos. I've also added a small amount of debug logging that was invaluable to me while porting over ipc-channel to illumos. I'm also happy to set up cross-compile CI, and if there's interest then I could chat with folks at Oxide about providing resources for runtime CI as well.
sunshowers
commented
Oct 28, 2024
Comment on lines
+54
to
57
| #[cfg(not(any(target_os = "linux", target_os = "illumos")))] | ||
| const SOCK_FLAGS: c_int = 0; | ||
|
|
||
| #[cfg(target_os = "linux")] |
There was a problem hiding this comment.
illumos also has MSG_CMSG_CLOEXEC but that isn't exposed in libc -- will put up a PR to add that to libc, and update this code when that's ready.
There was a problem hiding this comment.
Ah turns out it is incredibly recent, just 3 months old haha. illumos/illumos-gate@0250c53
|
We've merged OpenBSD support previously without adding explicit CI for it. I'd probably lump Illumos into a similar bucket; it's provided as a best-effort by contributors who have access to hardware and motivation to support it. |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, ipc-channel works and the full test suite passes on illumos. I've also added a small amount of debug logging that was invaluable to me while porting over ipc-channel to illumos.
I'm also happy to set up cross-compile CI, and if there's interest then I could chat with folks at Oxide about providing resources for runtime CI as well.