Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the cc property from the emit task #1074

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Remove the cc property from the emit task #1074

merged 1 commit into from
Jan 27, 2025

Conversation

cdavernas
Copy link
Member

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:
#1073

What this PR does:

  • Removes the cc property from the emit task

@cdavernas cdavernas added change: feature New feature or request. Impacts in a minor version change area: spec Changes in the Specification change: breaking A breaking change that will impact in a major version change. area: examples type: regression Indicates an issue caused by a regression or a feature that removes previously introduced functional labels Jan 27, 2025
@cdavernas cdavernas added this to the v1.0.0 milestone Jan 27, 2025
@cdavernas cdavernas self-assigned this Jan 27, 2025
@cdavernas cdavernas linked an issue Jan 27, 2025 that may be closed by this pull request
Remove the emit task's cc property #1073
Closed
@cdavernas cdavernas requested a review from fjtirado January 27, 2025 12:45
fjtirado
fjtirado approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @cdavernas!

@ricardozanini ricardozanini merged commit 9de4c03 into serverlessworkflow:main Jan 27, 2025
3 checks passed
cdavernas added a commit to serverlessworkflow/sdk-net that referenced this pull request Jan 30, 2025
@cdavernas
feat(Core): Removed cc property from the ListenTaskDefinition, as…
16cde52 
… per serverlessworkflow/specification#1074

fix(Solution): Updated solution packages

Signed-off-by: Charles d'Avernas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@fjtirado fjtirado fjtirado approved these changes

Assignees

@cdavernas cdavernas

Labels
area: examples area: spec Changes in the Specification change: breaking A breaking change that will impact in a major version change. change: feature New feature or request. Impacts in a minor version change type: regression Indicates an issue caused by a regression or a feature that removes previously introduced functional
Projects
Progress Tracker
Status: Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Remove the emit task's cc property
3 participants
@cdavernas @ricardozanini @fjtirado