Suggestion: use SubtleCrypto digest over @oslojs/crypto for sha256 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My understanding is that contrary to #110 this feature would be present in Cloudflare workers: https://developers.cloudflare.com/workers/runtime-apis/web-crypto/ |
|
@sergiodxa any opinions on this? Would you rather have it in our out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in this discussion it seems possible to drop the dependency on
@oslojs/cryptoin favour of using SubtleCrypto.The main argument towards this would be to reduce the number of dependencies at play.
There are additional aspects that SubtleCrypto does not block the event loop and has faster digest computations for bigger inputs. For the expected sizes of 32 bytes this is not a direct issue here.