use SubtleCrypto digest over @oslojs/crypto for sha256

sergiodxa · Aug 6, 2024 · 2be6889 · 2be6889
1 parent 7438a39
commit 2be6889
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/bun.lockb b/bun.lockb
diff --git a/package.json b/package.json
@@ -36,7 +36,6 @@
 		"./package.json": "./package.json"
 	},
 	"dependencies": {
-		"@oslojs/crypto": "^0.6.2",
 		"@oslojs/encoding": "^0.4.1",
 		"@oslojs/oauth2": "^0.5.0",
 		"debug": "^4.3.4"

diff --git a/src/lib/authorization-code.ts b/src/lib/authorization-code.ts
@@ -4,7 +4,6 @@
  * direction of the library to focus on response parsing, I decided to copy the
  * old code and adapt it to the new structure of the library.
  */
-import { sha256 } from "@oslojs/crypto/sha2";
 import { encodeBase64urlNoPadding } from "@oslojs/encoding";
 
 export namespace AuthorizationCode {
@@ -33,8 +32,13 @@ export namespace AuthorizationCode {
 			this.searchParams.set("state", state);
 		}
 
-		public setS256CodeChallenge(codeVerifier: string): void {
-			const codeChallengeBytes = sha256(new TextEncoder().encode(codeVerifier));
+		public async setS256CodeChallenge(codeVerifier: string): Promise<void> {
+			const codeChallengeBytes = new Uint8Array(
+				await crypto.subtle.digest(
+					"SHA-256",
+					new TextEncoder().encode(codeVerifier),
+				),
+			);
 			const codeChallenge = encodeBase64urlNoPadding(codeChallengeBytes);
 			this.searchParams.set("code_challenge", codeChallenge);
 			this.searchParams.set("code_challenge_method", "S256");