Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyspace-client #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

smirnovslava189
Copy link

fix: corrected typos in code and documentation
docs: updated documentation and fixed minor inconsistencies

  • Updated README.md to clarify argument descriptions for scripts:
    • Adjusted descriptions for --private-key and --signature-type to include proper format.
  • Improved docs/pages/index.mdx:
    • Corrected typos and improved phrasing in the project description.
    • Added missing links for Coinbase Smart Wallet and JavaScript Client.
  • Ensured consistency across documentation regarding smart wallet configurations and features.
    docs/pages/revoking-signers.mdx:

Improved the description of the process for revoking compromised signers.
Clarified the critical importance of maintaining wallet security in scenarios where a signer is compromised.
Enhanced the section on preconfirming revocations on active chains for better clarity.
Added information about potential solutions for cross-chain synchronization issues.
docs/pages/roadmap.mdx:

Updated the "Cross-Chain Syncing Improvements" section with plans to support chains using EP-4788.
Added a description of the new resilient fallback syncing method to improve reliability.
Clarified details on standardized access to oracles for safer cross-chain operations.

1. Simplified complex and lengthy sentences to improve readability. For example, rephrased a sentence in the "Signing Key Indexer" section for better clarity.
2. Added context to the link for "[Safe Transaction Service](https://docs.safe.global/core-api/api-safe-transaction-service)" to help readers understand its purpose.
3. Suggested formatting the functionality of the "Multisig Transaction Service" as a list to make the structure clearer and easier to follow.
4. Discussed unifying headings and proposed renaming "Multisig Transaction Service" to "Multisig Transaction Management Service" for consistency.
5. Recommended splitting long paragraphs into shorter ones and adding more examples of service usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant