Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping sqllite version #47

Merged
merged 3 commits into from
Jul 26, 2024
Merged

bumping sqllite version #47

merged 3 commits into from
Jul 26, 2024

Conversation

swampie
Copy link
Member

@swampie swampie commented Jul 17, 2024

Reopening this because of wrong merge.

@swampie swampie requested a review from pditommaso July 17, 2024 13:08
@swampie
Copy link
Member Author

swampie commented Jul 17, 2024

DId test pass? @pditommaso
Yes

@swampie
Copy link
Member Author

swampie commented Jul 17, 2024

image

@pditommaso
Copy link
Contributor

The CI tests, it looks like are not running

@alvaromartmart
Copy link
Member

I don't understand why the gha workflow is not being triggered:

name: MigTool continuous build
# read more here
# https://help.github.com/en/articles/workflow-syntax-for-github-actions#on
on:
push:
branches:
- '*'
- '!refs/tags/.*'
tags-ignore:
- '*'

the commits don't contain [ci skip] either. This is weird

@alvaromartmart
Copy link
Member

I don't understand why the gha workflow is not being triggered:

actually... please check something @swampie: your commits don't show up as verified, maybe this repo is configured not to run Github Actions for unverified commits?

@tcrespog
Copy link
Contributor

I don't understand why the gha workflow is not being triggered:

actually... please check something @swampie: your commits don't show up as verified, maybe this repo is configured not to run Github Actions for unverified commits?

I believe this is due to the branch name containing /.

I think this should be ** for it to work:

Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso
Copy link
Contributor

@tcrespog yeah, you are right

@pditommaso pditommaso merged commit 4725b89 into master Jul 26, 2024
2 checks passed
@pditommaso
Copy link
Contributor

Is a release needed for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants