Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of null ScriptLines #220

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ibevers
Copy link
Collaborator

@ibevers ibevers commented Dec 11, 2024

Description

Related Issue(s)

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@ibevers ibevers linked an issue Dec 11, 2024 that may be closed by this pull request
1 task
@ibevers ibevers changed the title Remove non-null text and speaker validator Allow creation of null ScriptLines Dec 11, 2024
@ibevers ibevers marked this pull request as ready for review December 11, 2024 21:10
@fabiocat93
Copy link
Collaborator

hi @ibevers , I have asked some questions in the related issue. I want to understand better when these changes can be helpful and if more generalizability is needed

@fabiocat93 fabiocat93 marked this pull request as draft December 23, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Allow Null ScriptLines
2 participants