Skip to content
This repository has been archived by the owner on Jun 4, 2019. It is now read-only.

Commit

Permalink
commit v1.6.5
Browse files Browse the repository at this point in the history
* remove clearing from `inc/classes/gallery.php` due to too many
recurring conflicts with Foundation clearing functionality
  • Loading branch information
Piet Bos committed Sep 18, 2015
1 parent e50bad7 commit 731ea7f
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 12 deletions.
15 changes: 10 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
soblossom WordPress theme
=========

###### Version 1.6.3
###### Last updated on 2015.08.16
###### Version 1.6.5
###### Last updated on 2015.09.18
###### Foundation version 5.5.2
###### FontAwesome version 4.4.0
###### [DEMO SITE](http://so-wp.com/themes/soblossom/)
Expand All @@ -26,9 +26,9 @@ All Featured Images, for example those on a Single Post, come with the builtin [

### Gallery Shortcode

For the soblossom theme we have completely overhauled the default WordPress Gallery shortcode. You won't find any inline styling either. We have replaced the functionality with [Foundation Blockgrid](http://foundation.zurb.com/docs/components/block_grid.html) **and** [Foundation Clearing Thumbs](http://foundation.zurb.com/docs/components/clearing.html), which shows the images with a cool lightbox effect, so you won't need an additional plugin for that either.
By default the blockgrid shows `small-block-grid-2 medium-block-grid-3 large-block-grid-4`, which means that on small devices (up to 640px wide) it shows 2 thumbs; on medium devices (640-1024px wide) it shows 3 thumbs and on large devices (anything over 1024px) it will show 4 thumbs. Clicking on a thumb will show the Foundation Clearing effect.
If you want to adjust anything, you can do so in `inc/classes/gallery.php` and the `scss/_gallery.scss` files.
For the soblossom theme we have completely overhauled the default WordPress Gallery shortcode. You won't find any inline styling either. We have replaced the functionality with [Foundation Blockgrid](http://foundation.zurb.com/docs/components/block_grid.html). Since [v1.6.5](https://github.com/senlin/soblossom/releases/tag/v1.6.5) we have removed the clearing from the soblossom gallery shortcode, due to too many inconsistencies and ongoing (or recurring) conflicts.
By default the blockgrid shows `small-block-grid-2 medium-block-grid-3 large-block-grid-4`, which means that on small devices (up to 640px wide) it shows 2 thumbs; on medium devices (640-1024px wide) it shows 3 thumbs and on large devices (anything over 1024px) it will show 4 thumbs.If you want to adjust anything, you can do so in `inc/classes/gallery.php` and the `scss/_gallery.scss` files.
If you want to have a lightbox effect we recommend using the [WP Featherlight](https://wordpress.org/plugins/wp-featherlight/) plugin.
Showing your galleries this way means that whatever you choose as amount of columns in the WordPress interface will have no effect on the frontend. That is the "price you pay" for awesomeness. Of course you can remove the function and let WordPress do it its own way too.

### Other Foundation Features
Expand Down Expand Up @@ -98,6 +98,7 @@ Included is a sample Gruntfile.js that you can use as a start.
### Can I also use soblossom without Grunt?

Yes, of course you can! Then you can just ignore all the stuff about Grunt. At the top of the `soblossom_scripts()` function, which enqueues the styles and scripts, you can find an explanation and an alternative. You can find this function in the `inc/soblossom.php` file.

## Credits

Nowadays there are plenty of WordPress themes built on Foundation and we have looked at a few of them: [Reverie](https://github.com/milohuang/reverie) by [Zhen Huang](https://github.com/milohuang), [Required+](https://github.com/wearerequired/required-foundation) (discontinued) by [Required+](http://required.ch/who-we-are/), [WPForge](http://wpforge.themeawesome.com/) by T. Vasquez and last but not least [JointsWP](http://jointswp.com/) by [Jeremy Englert](http://twitter.com/jeremyenglert). Thanks all for your guidance, tips and inspiration!
Expand Down Expand Up @@ -125,6 +126,10 @@ Nowadays there are plenty of WordPress themes built on Foundation and we have lo

## Changelog

### 1.6.5 (date 2015.09.18)

* remove clearing from `inc/classes/gallery.php` due to too many recurring conflicts with Foundation clearing functionality. For an always working responsive lightbox we recommend to use [WP Featherlight](https://wordpress.org/plugins/wp-featherlight/) instead, which looks almost the same and is much more consistent and reliable.

### 1.6.4 (date 2015.08.18)

* critical update, fixes bug that made it impossible to change site description
Expand Down
2 changes: 1 addition & 1 deletion css/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -8230,7 +8230,7 @@ embed, iframe, object {

/******************************************************************
Stylesheet: soblossom_clearing_blockgrid_gallery
Stylesheet: soblossom_blockgrid_gallery
Adjust where necessary
Expand Down
6 changes: 3 additions & 3 deletions inc/classes/gallery.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@


remove_shortcode( 'gallery' );
add_shortcode( 'gallery', 'soblossom_clearing_blockgrid_gallery' );
add_shortcode( 'gallery', 'soblossom_blockgrid_gallery' );

/**
* The Gallery shortcode.
Expand Down Expand Up @@ -35,7 +35,7 @@
* }
* @return string HTML content to display gallery.
*/
function soblossom_clearing_blockgrid_gallery( $attr ) {
function soblossom_blockgrid_gallery( $attr ) {
$post = get_post();

static $instance = 0;
Expand Down Expand Up @@ -156,7 +156,7 @@ function soblossom_clearing_blockgrid_gallery( $attr ) {
}

$size_class = sanitize_html_class( $atts['size'] );
$gallery_div = "<div id='gallery-{$id}' class='soblossom-gallery'><ul class='clearing-thumbs small-block-grid-2 medium-block-grid-3 large-block-grid-4' data-clearing>";
$gallery_div = '<div id="gallery-{$id}" class="soblossom-gallery"><ul class="small-block-grid-2 medium-block-grid-3 large-block-grid-4">';

/**
* Filter the default gallery shortcode CSS styles.
Expand Down
2 changes: 1 addition & 1 deletion languages/soblossom.pot
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ msgid ""
msgstr ""
"Project-Id-Version: soblossom 1.6.4\n"
"Report-Msgid-Bugs-To: http://wordpress.org/support/theme/style\n"
"POT-Creation-Date: 2015-08-18 09:12:23+00:00\n"
"POT-Creation-Date: 2015-09-18 02:40:20+00:00\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=utf-8\n"
"Content-Transfer-Encoding: 8bit\n"
Expand Down
2 changes: 1 addition & 1 deletion scss/_gallery.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/******************************************************************
Stylesheet: soblossom_clearing_blockgrid_gallery
Stylesheet: soblossom_blockgrid_gallery
Adjust where necessary
Expand Down
2 changes: 1 addition & 1 deletion scss/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ This theme, is licensed under the GPL.
$fa-font-path: "../bower_components/fontawesome/fonts/";
@import "../../fontawesome/scss/font-awesome";

// Import soblossom_clearing_blockgrid_gallery styling
// Import soblossom_blockgrid_gallery styling
@import "gallery";

// Import comments styling
Expand Down

0 comments on commit 731ea7f

Please sign in to comment.