Changed IPNetwork copy assignment implementation to copy-and-swap.
#1681
Conversation
…he internal network. This change fixes use of memory after being freed in case of self-assignment and provides a strong exception guarantee.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1681 +/- ##
==========================================
- Coverage 83.61% 83.60% -0.01%
==========================================
Files 273 273
Lines 47565 47555 -10
Branches 9758 9789 +31
==========================================
- Hits 39770 39757 -13
- Misses 6926 6929 +3
Partials 869 869
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Common++/header/IpAddress.h
Outdated
| m_IPv4Network = std::unique_ptr<IPv4Network>(new IPv4Network(other)); | ||
|
|
||
| auto newNetwork = std::unique_ptr<IPv4Network>(new IPv4Network(other)); | ||
| m_IPv4Network = std::move(newNetwork); |
There was a problem hiding this comment.
I don't think it's necessary to use std::move here since a smart pointer is already cheap.
I would just use m_IPv4Network = std::unique_ptr<IPv4Network>(new IPv4Network(other)); for clearance.
There was a problem hiding this comment.
I guess the operations can be merged. Both should compile down to the same tho.
There was a problem hiding this comment.
@Dimi1010 I also think it will be the same after the compilation optimization. Then could you just merge the lines, so it looks cleaner?
There was a problem hiding this comment.
Should be good now.
|
Seems there is a CI failure, but should be unrelated. |
…eladb#1681) * Changed `IPNetwork` copy assignment implementation to copy-and-swap the internal network. This change fixes use of memory after being freed in case of self-assignment and provides a strong exception guarantee. * Removed the temporary variable.
This change fixes use of memory after being freed in case of self-assignment and provides a strong exception guarantee.