Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lifetime issue of startup mutex and condition variable in PfRingDevice. #1679

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

Dimi1010
Copy link
Collaborator

@Dimi1010 Dimi1010 commented Jan 4, 2025

Minimal viable fix of #1664 based on #1668.

@Dimi1010 Dimi1010 changed the title Fixed lifetime issue of startup mutex and condition variable. Fixed lifetime issue of startup mutex and condition variable in PfRingDevice. Jan 4, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.15%. Comparing base (7898a5d) to head (38b956b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1679      +/-   ##
==========================================
- Coverage   83.16%   83.15%   -0.01%     
==========================================
  Files         277      277              
  Lines       48201    48200       -1     
  Branches     9932     9974      +42     
==========================================
- Hits        40086    40082       -4     
+ Misses       7266     7240      -26     
- Partials      849      878      +29     
Flag Coverage Δ
alpine320 75.15% <ø> (ø)
fedora40 75.17% <ø> (+<0.01%) ⬆️
macos-13 80.65% <ø> (ø)
macos-14 80.65% <ø> (-0.01%) ⬇️
macos-15 80.63% <ø> (ø)
mingw32 70.87% <ø> (-0.05%) ⬇️
mingw64 70.86% <ø> (-0.03%) ⬇️
npcap 85.23% <ø> (-0.09%) ⬇️
rhel94 75.03% <ø> (ø)
ubuntu2004 58.63% <ø> (+<0.01%) ⬆️
ubuntu2004-zstd 58.74% <ø> (+0.01%) ⬆️
ubuntu2204 74.97% <ø> (+<0.01%) ⬆️
ubuntu2204-icpx 61.40% <ø> (-0.04%) ⬇️
ubuntu2404 75.20% <ø> (-0.02%) ⬇️
unittest 83.15% <ø> (-0.01%) ⬇️
windows-2019 85.33% <ø> (-0.01%) ⬇️
windows-2022 85.36% <ø> (-0.01%) ⬇️
winpcap 85.33% <ø> (ø)
xdp 50.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimi1010 Dimi1010 marked this pull request as ready for review January 5, 2025 08:23
@Dimi1010 Dimi1010 requested a review from seladb as a code owner January 5, 2025 08:23
@tigercosmos tigercosmos merged commit e0ca321 into seladb:dev Jan 8, 2025
41 checks passed
@Dimi1010 Dimi1010 deleted the fix/issue-1664-b branch January 8, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PfRingDevice::startCaptureSingleThread maybe crash after exits the funtion
3 participants